Private delegates in C# -


i'm working class contains several variants of private method. currently, i'm using enum select appropriate 1 within exposed method so.

public class myclass {     public enum myenum { type1, type2, type3, type4 };      private myenum _type;       public myclass(myenum type)     {         type = type;     }       public myenum type     {         { return _type; }         set { _type = value; }     }       public int function(int x, int y)     {         switch(_type)         {             case myenum.type1:                 return function1(x,y);             case myenum.type2:                 return function2(x,y);             case myenum.type3:                 return function3(x, y);             case myenum.type4:                 return function4(x, y);         }     }       private int function1(int x, int y)     {         // function variant 1     }       private int function2(int x, int y)     {         // function variant 2     }       private int function3(int x, int y)     {         // function variant 3     }       private int function4(int x, int y)     {         // function variant 4     }  }

this works fine i'm wondering if i'd better off going private delegate updated whenever enum changes. since, in case, public method called more enum setter.

public class myclass {     public enum myenum { type1, type2, type3, type4 };      private func<int, int, int> _function;     private myenum _type;       public myclass(myenum type)     {         type = type;     }       public myenum type     {         { return _type; }         set         {             _type = value;             ontypechange();         }     }       private void ontypechange()     {         switch (_type)         {             case myenum.type1:                 _function = function1;                 return;             case myenum.type2:                 _function = function2;                 return;             case myenum.type3:                 _function = function3;                 return;             case myenum.type4:                 _function = function4;                 return;         }     }       public int function(int x, int y)     {         return _function(x, y);     }       private int function1(int x, int y)     {         // function variant 1     }       private int function2(int x, int y)     {         // function variant 2     }       private int function3(int x, int y)     {         // function variant 3     }       private int function4(int x, int y)     {         // function variant 4     }  }

i suppose i'm looking conventional wisdom on subject. how sort of thing typically handled out in wild?

your second option technically better, because don't have go through switch every time public method called.

the first bit more readable.

in reality though, switching behavior on enum decent sized red flag. subclass myclass , use polymorphism desired behavior. consider doing in case. "in wild", that's approach use.


Comments

Post a Comment

Popular posts from this blog

javascript - Using jquery append to add option values into a select element not working -

i'm looking dynamically populate select element names of items stored array. for reason it's not working , i'm not sure why. html: <div class="col-md-4 col-md-offset-4"> <select class="select1"> </select> , <select class="select2"> </select> </div> note i'm using bootstrap layout. here's jquery i'm using try , populate ".select1" jquery: select: function() { $.each(state.greens, function(index, value) { $(".select1").append("<option value =' " + index + " '>" + state.greens[index].name + "</option>"); }); } note function 'select' stored within object called 'display'. state.greens name of array i'm trying access. so @ end of html page call display.select(); call function. no error messages showing in console. also, saw question: appending
Read more

Android soft keyboard reverts to default keyboard on orientation change -

i'm building android soft keyboard , can't seem fix bug - have arabic , qwerty keyboard , when rotate device on qwerty keyboard (or arabic shift), it's if program has "restarted" , becomes arabic keyboard without shift. the onsaveinstancestate(bundle savedinstancestate) not work because application not extend activity inputmethodservice . i put following in android manifest android:configchanges="keyboard|keyboardhidden|orientation" android:windowsoftinputmode="stateunchanged|adjustresize"> i tried using @override public void onconfigurationchanged(configuration newconfig) { super.onconfigurationchanged(newconfig); log.i(mydebug, "config changed " + currentkeyboard.equals(qwerty)); } however, currentkeyboard.equals(qwerty)) results false , made sure true before orientation change. any appreciated. i think applications fault. if application restarting on orientation change
Read more

Rendering JButton to get the JCheckBox behavior in a JTable by using images does not update my table -

i rendering jbutton image on simulate jcheckbox behavior. why don't let jtable render jcheckbox? because need bigger checkboxes , there's no way can resize them (as far know). so, have own table cell renderer , editor. both renders jbutton , checkbox images on them. trying change image checked image unchecked image (or vice versa) , update cell value (boolean true or false). however, reason, getcelleditorvalue() not update table. so, release mouse, value goes original one. any appreciated! lot! public class tableexample extends jframe { jscrollpane pane; jpanel panel; jtable table; object[][] data; mytablemodel tm; renderer buttoncolumn; public tableexample(object[][] data) throws ioexception { string[] columns = {"column#1", "column#2", "column#3", "column#4", "column#5", "column#6"}; this.data = data; this.setpreferredsize(new dimension(700, 500));
Read more