swift - Remove repeated code possible, is there a more elegant solution? -


i'm new swift...

i loop through hand of cards (not shown below), , compare each card determined best option. if has better value, replace struct variable "bestoption" card , appropriate value (penaltyvalue, arbitrary, can -5, -1, 9, 199, doesn't matter question).

so each card in hand call "comparereplacebestoption" card.

the bestoption variable, struct, empty (none value) , therefor filled first card , value. each following card compare (and possibly replace) card value in bestoption variable (which of value).

this code ugly several reasons (all advice appreciated), strikes me double assignment variable bestoption (a struct).

question: there more elegant solution there 1 assignment (i create small function assignment, end conceptually same issue)

having statement twice hurts...

    bestoption = ( card                  , newpenaltyvalue                  )

(side information: g.cardstack[0] in previous turn played card face on stack. handcards compared card)

    //find penalty , card card in hand lowest possible penalty     //and without using bonuschip     var bestoption: (card: card!, penaltyvalue: int!)?      func comparereplacebestoption(card: card) {         let newpenaltyvalue = card.nr - g.cardstack[0].nr - 1         if bestoption == nil {  bestoption = ( card                                              , newpenaltyvalue                                              )                              }  else                              {  if ( newpenaltyvalue < bestoption!.penaltyvalue ) {                                      bestoption = ( card                                                   , newpenaltyvalue                                                   )                                 }                              }     }

updated swift 3.0:

if let best = bestoption, best.penaltyvalue > newpenaltyvalue {     best = (car, newpenaltyvalue) }

(really losing where clause.)

old updated answer:

after revisiting answer, think can improve make more swifty:

if let best = bestoption best.penaltyvalue > newpenaltyvalue {     best = (car, newpenaltyvalue) }

we use optional unwrapping feature , where-clause provide addition cases check against (even using now-unwrapped best). easier read , drop pesky !.

original answer:

how about:

if bestoption == nil || newpenaltyvalue < bestoption!.penaltyvalue {     bestoption = (car, newpenaltyvalue) }

Comments

Post a Comment

Popular posts from this blog

javascript - Using jquery append to add option values into a select element not working -

i'm looking dynamically populate select element names of items stored array. for reason it's not working , i'm not sure why. html: <div class="col-md-4 col-md-offset-4"> <select class="select1"> </select> , <select class="select2"> </select> </div> note i'm using bootstrap layout. here's jquery i'm using try , populate ".select1" jquery: select: function() { $.each(state.greens, function(index, value) { $(".select1").append("<option value =' " + index + " '>" + state.greens[index].name + "</option>"); }); } note function 'select' stored within object called 'display'. state.greens name of array i'm trying access. so @ end of html page call display.select(); call function. no error messages showing in console. also, saw question: appending
Read more

Android soft keyboard reverts to default keyboard on orientation change -

i'm building android soft keyboard , can't seem fix bug - have arabic , qwerty keyboard , when rotate device on qwerty keyboard (or arabic shift), it's if program has "restarted" , becomes arabic keyboard without shift. the onsaveinstancestate(bundle savedinstancestate) not work because application not extend activity inputmethodservice . i put following in android manifest android:configchanges="keyboard|keyboardhidden|orientation" android:windowsoftinputmode="stateunchanged|adjustresize"> i tried using @override public void onconfigurationchanged(configuration newconfig) { super.onconfigurationchanged(newconfig); log.i(mydebug, "config changed " + currentkeyboard.equals(qwerty)); } however, currentkeyboard.equals(qwerty)) results false , made sure true before orientation change. any appreciated. i think applications fault. if application restarting on orientation change
Read more

Rendering JButton to get the JCheckBox behavior in a JTable by using images does not update my table -

i rendering jbutton image on simulate jcheckbox behavior. why don't let jtable render jcheckbox? because need bigger checkboxes , there's no way can resize them (as far know). so, have own table cell renderer , editor. both renders jbutton , checkbox images on them. trying change image checked image unchecked image (or vice versa) , update cell value (boolean true or false). however, reason, getcelleditorvalue() not update table. so, release mouse, value goes original one. any appreciated! lot! public class tableexample extends jframe { jscrollpane pane; jpanel panel; jtable table; object[][] data; mytablemodel tm; renderer buttoncolumn; public tableexample(object[][] data) throws ioexception { string[] columns = {"column#1", "column#2", "column#3", "column#4", "column#5", "column#6"}; this.data = data; this.setpreferredsize(new dimension(700, 500));
Read more