jquery - Javascript function overwriting itself -


sorry title isn't clear, i'm not sure problem is. i'll happily rename if has better idea.

i have bunch of boxes classes 'something-box' called clicking various things have given classes of 'something-button'. boxes have class of 'modal-box' , contained within partially transparent div comes cover rest of screen ('modal-blackout'). rather write same code out each 1 (which doing) decided make function attach relevant click handlers each button (and various other things accompany it). have following js code:

    function modal(selector) {         button = $(selector+'-button');         box = $(selector+'-box');         button.click(function(e) {             e.stoppropagation();             $('.modal-box').hide();             $(document).off('.hidedoc');             $('.modal-blackout').show();             box.show();             $(document).on('click.hidedoc', function(e) {                  if (!box.is(e.target) && box.has(e.target).length === 0)                 {                     $('.modal-blackout').hide();                     box.hide();                     $(selector + '-box .error-message').html('');                     $(document).off('.hidedoc');                 }             });             e.preventdefault();         });     }      modal('.password-reset');     modal('.login');     modal('.signup');

but every button brings .signup-box (or whichever 1 called last). note if remove function , write out 3 times manually different selectors everywhere in code, works intended.

suspect there fundamental don't understand here. can explain?

you're creating global variables being overridden each time modal() called. results in box referring box selected last selector, , similar button.

for button, it's not problem, since use once. however, reference box has stay accurate, because it's used in click event handler.

replace:

function modal(selector) {     button = $(selector+'-button');     box = $(selector+'-box');

with:

function modal(selector) {     var button = $(selector+'-button');     var box = $(selector+'-box');

this result in variables being created in modal's scope, subsequent calls modal can't override variables set previous selectors.


Comments

Post a Comment

Popular posts from this blog

javascript - Using jquery append to add option values into a select element not working -

i'm looking dynamically populate select element names of items stored array. for reason it's not working , i'm not sure why. html: <div class="col-md-4 col-md-offset-4"> <select class="select1"> </select> , <select class="select2"> </select> </div> note i'm using bootstrap layout. here's jquery i'm using try , populate ".select1" jquery: select: function() { $.each(state.greens, function(index, value) { $(".select1").append("<option value =' " + index + " '>" + state.greens[index].name + "</option>"); }); } note function 'select' stored within object called 'display'. state.greens name of array i'm trying access. so @ end of html page call display.select(); call function. no error messages showing in console. also, saw question: appending
Read more

Android soft keyboard reverts to default keyboard on orientation change -

i'm building android soft keyboard , can't seem fix bug - have arabic , qwerty keyboard , when rotate device on qwerty keyboard (or arabic shift), it's if program has "restarted" , becomes arabic keyboard without shift. the onsaveinstancestate(bundle savedinstancestate) not work because application not extend activity inputmethodservice . i put following in android manifest android:configchanges="keyboard|keyboardhidden|orientation" android:windowsoftinputmode="stateunchanged|adjustresize"> i tried using @override public void onconfigurationchanged(configuration newconfig) { super.onconfigurationchanged(newconfig); log.i(mydebug, "config changed " + currentkeyboard.equals(qwerty)); } however, currentkeyboard.equals(qwerty)) results false , made sure true before orientation change. any appreciated. i think applications fault. if application restarting on orientation change
Read more

Rendering JButton to get the JCheckBox behavior in a JTable by using images does not update my table -

i rendering jbutton image on simulate jcheckbox behavior. why don't let jtable render jcheckbox? because need bigger checkboxes , there's no way can resize them (as far know). so, have own table cell renderer , editor. both renders jbutton , checkbox images on them. trying change image checked image unchecked image (or vice versa) , update cell value (boolean true or false). however, reason, getcelleditorvalue() not update table. so, release mouse, value goes original one. any appreciated! lot! public class tableexample extends jframe { jscrollpane pane; jpanel panel; jtable table; object[][] data; mytablemodel tm; renderer buttoncolumn; public tableexample(object[][] data) throws ioexception { string[] columns = {"column#1", "column#2", "column#3", "column#4", "column#5", "column#6"}; this.data = data; this.setpreferredsize(new dimension(700, 500));
Read more