ios - How to maintain proper encapsulation for singleton created with data -


i have singleton networking class singleton object needs persist throughout app. singleton initialized based on data retrieved web call, right code works, , have following in singleton networking class:

- (void)initializeobjectwithsuccess:(void (^)(bool))success                                  failure:(void (^)(nserror *error))failure { [self.httpclient postpath:[nsstring stringwithformat:@"users/%@/", [cpuser shareduser].name parameters:[self createparameters] success:^(afhttprequestoperation *operation, id responseobject) {     id json = [nsjsonserialization jsonobjectwithdata:responseobject                                               options:nsjsonreadingallowfragments                                                 error:nil];      [[cplist sharedlist] setidentifier:json[@"id"]];     [[cplist sharedlist] setimages:json[@"images"]];     if (success) {         success(yes);     }  } failure:^(afhttprequestoperation *operation, nserror *error) {     failure(error); }]; }

i don't know how initialize properties need on singleton cplist without setting them within method, know not proper encapsulation because cprequestmanager class should know nothing cplist class

if issue don't want class know name of cplist , detail it's singleton , can access +[cplist sharedinstance] can pass in object conforms protocol. moves knowledge of singleton somewhere else

- (void)initializeobjectwithlist:(id<cplist>)list                          success:(void (^)(bool))success                          failure:(void (^)(nserror *error))failure; {   [self.httpclient postpath:[nsstring stringwithformat:@"users/%@/", [cpuser shareduser].name parameters:[self createparameters] success:^(afhttprequestoperation *operation, id responseobject) {       id json = [nsjsonserialization jsonobjectwithdata:responseobject                                                 options:nsjsonreadingallowfragments                                                   error:nil];         [list setidentifier:json[@"id"]];       [list setimages:json[@"images"]];       if (success) {           success(yes);       }    } failure:^(afhttprequestoperation *operation, nserror *error) {       failure(error);   }]; }

or remove knowledge there "list" , have method return actual data , caller can set on list

- (void)initializeobjectwithsuccess:(void (^)(nsstring *id, nsarray *images))success                             failure:(void (^)(nserror *error))failure; {   [self.httpclient postpath:[nsstring stringwithformat:@"users/%@/", [cpuser shareduser].name parameters:[self createparameters] success:^(afhttprequestoperation *operation, id responseobject) {       id json = [nsjsonserialization jsonobjectwithdata:responseobject                                                 options:nsjsonreadingallowfragments                                                   error:nil];        if (success) {           success(json[@"id"], json[@"images"]);       }    } failure:^(afhttprequestoperation *operation, nserror *error) {       failure(error);   }]; }

without further context it's hard suggest structural changes here's 2 potential refactoring might thinking coudld do


Comments

Post a Comment

Popular posts from this blog

javascript - Using jquery append to add option values into a select element not working -

i'm looking dynamically populate select element names of items stored array. for reason it's not working , i'm not sure why. html: <div class="col-md-4 col-md-offset-4"> <select class="select1"> </select> , <select class="select2"> </select> </div> note i'm using bootstrap layout. here's jquery i'm using try , populate ".select1" jquery: select: function() { $.each(state.greens, function(index, value) { $(".select1").append("<option value =' " + index + " '>" + state.greens[index].name + "</option>"); }); } note function 'select' stored within object called 'display'. state.greens name of array i'm trying access. so @ end of html page call display.select(); call function. no error messages showing in console. also, saw question: appending
Read more

Android soft keyboard reverts to default keyboard on orientation change -

i'm building android soft keyboard , can't seem fix bug - have arabic , qwerty keyboard , when rotate device on qwerty keyboard (or arabic shift), it's if program has "restarted" , becomes arabic keyboard without shift. the onsaveinstancestate(bundle savedinstancestate) not work because application not extend activity inputmethodservice . i put following in android manifest android:configchanges="keyboard|keyboardhidden|orientation" android:windowsoftinputmode="stateunchanged|adjustresize"> i tried using @override public void onconfigurationchanged(configuration newconfig) { super.onconfigurationchanged(newconfig); log.i(mydebug, "config changed " + currentkeyboard.equals(qwerty)); } however, currentkeyboard.equals(qwerty)) results false , made sure true before orientation change. any appreciated. i think applications fault. if application restarting on orientation change
Read more

jquery - javascript onscroll fade same class but with different div -

i new @ javascript , want learn new. there wrong code : why div fades @ same time. i want ask how fade different div s same class name.can me , explain me. thanks in advance. javascript: $(window).scroll(function(){ if ($( "div.fade" ).offset().top - $(window).scrolltop() <= 100){ $('.fade').addclass( "fade-in"); } else { $('.fade').removeclass("fade-in"); } }); here jsfiddle onscroll = function () { var scrolltop = $(this).scrolltop() ; $("div.fade").each(function(){ if(($(this).offset().top - scrolltop) <= 100){ $(this).toggleclass("fade-in"); } }) }
Read more