Cannot download file from URL in java -


i'm making program download files url. downloading starts, not completed. example, if file's size 3 mb, program download half of cannot open downloaded file. program says file downloaded succesfully.

public class filedownloader {      public static void main (string [] args) throws ioexception {          inputstream filein;         fileoutputstream fileout;         scanner s = new scanner(system.in);          system.out.println("enter url: ");         string urlstr = s.nextline();          url url = new url(urlstr);         urlconnection urlconnect = url.openconnection();         filein = urlconnect.getinputstream();          system.out.println("enter file name: ");         string filestr = s.nextline();         fileout = new fileoutputstream(filestr);          while (filein.read() != -1) {                fileout.write(filein.read());         }         system.out.println("file downloaded");     } }

so how can solve it? should use way download?

you losing every alternate bytedue to

    while (filein.read() != -1) {     //1st read         fileout.write(filein.read());     //2nd read - 1st write     }

you reading twice , writing once.

what need 

    int x;     while ((x = filein.read()) != -1) {   //1st read         fileout.write(x);     //1st write     }

here complete code

import java.io.fileoutputstream; import java.io.ioexception; import java.io.inputstream; import java.net.url; import java.net.urlconnection; import java.util.scanner;  public class filedownloader {      public static void main(string[] args) throws ioexception {          inputstream filein;         fileoutputstream fileout;         scanner s = new scanner(system.in);          system.out.println("enter url: ");         string urlstr = s.nextline();          url url = new url(urlstr);         urlconnection urlconnect = url.openconnection();         filein = urlconnect.getinputstream();          system.out.println("enter file name: ");         string filestr = s.nextline();         fileout = new fileoutputstream(filestr);          int x;         while ((x = filein.read()) != -1) {             fileout.write(x);         }         system.out.println("file downloaded");  }

Comments

Post a Comment

Popular posts from this blog

searchKeyword not working in AngularJS filter -

i writing app using angularjs on front end. want search through table word/field; 1 search box everything. according article here: http://hello-angularjs.appspot.com/searchtable can use filter: searchkeyword this. this code, , not working expected. <label>search: <input ng-model="searchkeyword"></label> <table ng-repeat="post in posts | orderby: sort | filter: searchkeyword"> <tr> <td> {{index(post)}} </td> <td> {{post.title}} </td> <td> {{post.author}} </td> <td> {{post.content}} </td> <td> {{post.date | date: "d/m/yyyy"}} </td> </tr> </table> what should do? thank you try this: controller $scope.posts = [ {title:'title one', author:'author one', content: 'content one'}, {title:'title two', author:'author two', content: 'cont...
Read more

sequelize.js - Sequelize: sort by enum cases -

i have model ( article ) field (the name type ) of type enum('source', 'translated') , return 1 article ordered type field. source articles should returned before translated articles. like: article.findone(order: [ { type: [ 'source', 'translated' ] } ]); unfortunately there appears no built-in solution sorting enums. instead have sort by case , couldn't find documentation on how sequelize. what conventional approach here? sorting case hard in sequelize, sort field (the second answer in linked post) should possible: order: sequelize.fn('field', sequelize.col('type'), 'source', 'translated') it's supported mysql far know though
Read more

user interface - how to replace an ongoing process of image capture from another process call over the same ImageLabel in python's GUI TKinter -

i trying use following code create interactive gui changes color-space(hsv, rbg, grayscale etc) on event of button click. display opencv video in tkinter using multiprocessing being new python having problems multiprocessing , attempts on making gui change it's color space on button clicks hangs entire system. on it's implementation highly appreciated. thankyou. below code: import cv2 pil import image,imagetk import tkinter tk import numpy np multiprocessing import process , queue def quit_it(root,process): root.destroy() process.terminate() def black_andwhite(root,process): process.terminate p=process(target=capture_image, args=(5,queue, )) p.start() root.after(0, func=lambda: update_all(root, image_label, queue)) def update_image(image_label, queue): frame = queue.get() = image.fromarray(frame) b = imagetk.photoimage(image=a) image_label.configure(image=b) image_label._image_cache = b root.update() def update_all(root...
Read more